Skip to content

FE-1580: Port omitted Voice settlement behavior - #9588

Merged
kostandinang merged 6 commits into
mainfrom
kostandin/fe-1580-port-voice-settlement-fixes
Sep 9, 2026
Merged

FE-1580: Port omitted Voice settlement behavior#9588
kostandinang merged 6 commits into
mainfrom
kostandin/fe-1580-port-voice-settlement-fixes

Conversation

@kostandinang

@kostandinang kostandinang commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Note

Focused post-merge stabilization for #9564 and #9537. This semantically ports the settlement behavior omitted when #9564 imported #9531 only through be56a18ff0, including donor commit 9415e1b007.

Summary

  • Release canonical Voice ownership when an authorized completed Realtime response contains no audio, while preserving unrelated active playback.
  • Settle a completed, correlated Brunch submission even when it contains no canonical prose, so the next Voice turn can begin.
  • Keep a rejected durable Stop visible as an error after late provider completion and prevent deferred tools or continuation from resuming.
  • Remove the stale browser brunch_ask catalog entry without restoring the temporary shim.
  • Update the Mission 6b authority and existing changeset for the current-main follow-up.

Regression coverage

  • Silent terminal response releases only its matching speech request and restores capture.
  • Active audio remains owned until buffer stop even if terminal metadata omits audio.
  • Zero-segment completed Brunch turns settle and accept the next transcript.
  • A queued silent response does not interrupt unrelated playback.
  • Late provider completion cannot turn a failed durable Stop into success or run withheld work.
  • The production preview no longer registers brunch_ask.
  • Test teardown removes module-global toast state deterministically.

Verification

  • @apps/petrinaut-website: 5 affected files, 146 tests passed.
  • @hashintel/petrinaut: assistant panel file, 60 tests passed.
  • TypeScript checks passed for both affected workspaces.
  • ESLint passed with one existing warning in unchanged voice-interview-control.tsx.
  • Changed-file formatting, markdown lint, architecture lint, both affected builds, and git diff --check passed.

Scope

This does not include #9538 grounding/preview behavior, #9550 interruption or VAD changes, the snapshot-overlay defect, or the dual-rejection provenance rollback. No paid-provider, microphone, or audible-latency claim is made.

Made with Cursor

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Actions Updated
hash Ignored Ignored Preview Sep 9, 2026 6:44am UTC
hashdotdesign-tokens Ignored Ignored Preview Sep 9, 2026 6:44am UTC
petrinaut Skipped Skipped Sep 9, 2026 6:44am UTC
petrinaut-docs Skipped Skipped Sep 9, 2026 6:44am UTC

Request Review

kostandinang and others added 2 commits September 8, 2026 19:30
kostandinang and others added 2 commits September 8, 2026 19:31
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e41a9d2. Configure here.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
vercel Bot temporarily deployed to Preview – petrinaut September 9, 2026 06:43 Inactive
@vercel
vercel Bot temporarily deployed to Preview – petrinaut-docs September 9, 2026 06:43 Inactive

@lunelson lunelson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only issue is a process one, where FE-1626 is still indicated as the active mission

@kostandinang
kostandinang added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 338a63f Sep 9, 2026
63 checks passed
@kostandinang
kostandinang deleted the kostandin/fe-1580-port-voice-settlement-fixes branch September 9, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants